stefanseifert commented on a change in pull request #6: Added support for
simulating HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288744238
##########
File path:
src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java
##########
@@ -82,7 +83,7 @@
private final ResourceResolver resourceResolver;
private final RequestPathInfo requestPathInfo;
private Map<String, Object> attributeMap = new HashMap<String, Object>();
- private Map<String, String[]> parameterMap = new LinkedHashMap<String,
String[]>();
+ private Map<String, MockRequestParameter[]> parameterMap = new
LinkedHashMap<>();
Review comment:
hmm, the code is using the LinkedHashMap since 2014, although i do not see a
great need for it. to be on the safe side i would recommend using LinkedHashMap
in the MockRequestParameterMap as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
