stefanseifert commented on a change in pull request #6: Added support for 
simulating HTML forms (including file uploads)…
URL: 
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288744705
 
 

 ##########
 File path: 
src/test/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequestTest.java
 ##########
 @@ -316,6 +317,47 @@ public void testRequestParameter() throws Exception {
         assertEquals("param1", 
((MockRequestParameter)request.getRequestParameter("param1")).getName());
     }
 
+    @Test
+    public void testFormRequestParameters() throws Exception {
 
 Review comment:
   i think it's fine if the consolidated code part is tested at least on one 
path.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to