hi on the other hand: if there was a common coding style the community could agree on, modules would just go 1 time through a re-formatting commit, which could be committed just as this (SLING-xyz : reformat to comply with sling coding style). any following diffs would not be polluted, would they?
kind regards angela ________________________________ From: Bertrand Delacretaz <[email protected]> Sent: Tuesday, November 12, 2019 1:05 PM To: dev <[email protected]> Subject: Re: Code Styleguide Hi Radu, On Tue, Nov 12, 2019 at 12:29 PM Radu Cotescu <[email protected]> wrote: >... Another option would be to configure the maven-checkstyle-plugin [0] in >the parent pom and let > individual modules slowly implement the coding style once they update to a > newer parent... I'd prefer decoupling the choices of moving to a new parent pom and enforcing the style guide. I like your idea but would add a pom property that activates the style checks, to avoid having to reformat modules just because they need to upgrade the parent pom for another reason. Some modules might require extensive reformatting to comply with an enforced style guide, and as mentioned I don't like doing that as it pollutes the diffs, "just" to make code look optically nicer. -Bertrand
