+1
Carsten
Am 12.11.2019 um 16:11 schrieb Bertrand Delacretaz:
Hi,
On Tue, Nov 12, 2019 at 2:18 PM Angela Schreiber
<[email protected]> wrote:
...on the other hand: if there was a common coding style the community could
agree on, modules would just go 1 time through
a re-formatting commit, which could be committed just as this (SLING-xyz :
reformat to comply with sling coding style).
any following diffs would not be polluted, would they?..
My problem is that if that (potentially big) reformatting commit
happens at time T, comparing code before and after that time will show
lots of additional differences which are just formatting and blur the
picture of what actually changed.
For modules that are core and evolve slowly (engine, API, resolvers
etc.) I think that's a problem, as if something seems to have changed
in that code between (say) T - 1 year and T + 1 year it's really
useful to have minimal diffs to find out what actually changed.
I guess the question is how much people value nice code formatting vs.
minimal diffs. The latter is *much* more important for me, but maybe
it's just me.
-Bertrand
--
--
Carsten Ziegeler
Adobe Research Switzerland
[email protected]
