Sounds good to me. https://issues.apache.org/jira/browse/SLING-8900
Robert On Sat, 2019-12-07 at 14:52 +0100, Carsten Ziegeler wrote: > And we can probably make this a breaking change (meaning we don't > need > to support sourceId) as we just introduced this in the last version > and > I don't expect anyone to use it. > > Carsten > > Am 07.12.2019 um 12:07 schrieb Carsten Ziegeler: > > We should probably then use "source-ids" as it supports a list of > > ids. > > > > Carsten > > > > Am 06.12.2019 um 18:53 schrieb Andreas Schaefer: > > > I think consistency would be good so I am +1 on that source-id > > > > > > - Andy > > > > > > > On Dec 6, 2019, at 8:54 AM, Robert Munteanu <[email protected] > > > > > wrote: > > > > > > > > Hi, > > > > > > > > In the feature model definitions I see that most of the > > > > properties are > > > > written in kebab-case ( e.g. "scm-location" ), with the > > > > exception of > > > > the "sourceId" property. > > > > > > > > Would it make sense to rename this property to "source-id", for > > > > consistency? > > > > > > > > Thanks, > > > > Robert > > > >
