LOL meanwhile I posted https://github.com/apache/solr/pull/2424 for the script I developed and improved today. I think CHANGES.txt is the best source for a release centric view while git log is best for project health metrics.
On Fri, Apr 26, 2024 at 4:38 PM Jan Høydahl <jan....@cominvent.com> wrote: > > I think it is a good idea to include a list of contributors in the release > note mail. > it is a tiny encouragement for folks to contribute more. The list should > perhaps > be excluding committers, so we only list external contributors? > > I already added a script to dev-tools to parse SolrBot contributions from git > log and add to CHANGES: > https://github.com/apache/solr/blob/main/dev-tools/scripts/addDepsToChanges.py > > Based on this I did a similar script that parses out Authors and > Co-Authored-By from git log > since last release, see https://github.com/apache/solr/pull/2423 for a Draft. > > There's a risk of this method missing the names of some contributors who did > not actually commit anything to a PR but still are listed in CHANGES for the > release. That can be fixed by us being more careful when merging PRs, and > when committing patches from JIRA, > > Jan > > > 26. apr. 2024 kl. 15:39 skrev David Smiley <dsmi...@apache.org>: > > > > On Fri, Apr 26, 2024 at 9:35 AM Gus Heck <gus.h...@gmail.com> wrote: > >> > >> I don't know if it's relevant, but I recall that back in the early 2000's > >> around the time of the adoption of the ASL 2.0 (when I was contributing to > >> Ant) the ASF had us stop using @author tags in code. I was not a fan at the > >> time, but they had some reason I don't fully recall relating to shielding > >> the contributors in the event of someone hitting a bug and then trying to > >> sue folks to recover losses or something. I wonder if that logic still > >> exists, and if this could be seen as related to that. It's also possible > >> that this memory has severely mutated while hanging out in the back of my > >> brain for 20 year :). > > > > The context of the name appearing as I propose in a "thank you" is > > merely to thank them, not to indirectly hold them to stability/quality > > measures. > > > > I don't think it's related. @author tags can repel a collaborative > > ownership mindset on a specific bit of code. I used to @author my > > code out of pride but long ago I realized those tags are a bad idea > > and also kind of needless with git-blame anyway. > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > > For additional commands, e-mail: dev-h...@solr.apache.org > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
