http://bugzilla.spamassassin.org/show_bug.cgi?id=4153
------- Additional Comments From [EMAIL PROTECTED] 2005-05-19 11:19 -------
Subject: Re: [review] RFE : Spamc patch for config file
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On (19/05/05 10:55), [EMAIL PROTECTED] didst pronounce:
> the 'cd $srcdir/spamc; perl configure.pl && make' case isn't supported;
> configure is only ever to be run from a top-level 'make'. so if that
> breaks, so be it, people aren't supposed to be building it like that ;)
> I wouldn't worry about that case at all.
>
Ah, ok. That makes things immensely easier so. I was working on the
basis that this _would_ be a supported build method for spamc.
> do we need to have any of that logic in spamc? can't that all be dealt
> with by Makefile.PL, and it just passes in a single string for SYSCONFDIR,
> which spamc uses?
>
Yes. Without the need to support building spamc on its own, all this is
covered already. Makefile.PL passes the relevant sysconfdir to
spamc/configure, so it'll be statically set in spamc.h. This means the
config file is #define'd to a single location, and can only be changed
using the -F command line option, and no funky preprocessing is needed.
If people want to build spamc separately, and need a config file
somewhere else, it can be changed in spamc.h before compilation. If you
want to semi-support building spamc separately, the macro in spamc.h.in
would cover it (for a case where --sysconfdir isn't passed to configure
by the person compiling it) for a single scenario -- the config file
would be defined to ${prefix}/etc/spamc.conf. It's not a necessary
addition, but it doesn't hurt either.
Sorted so. Without the changes to spamc.h.in, patch #2879 covers the
above. With the changes to spamc.h.in in #2879, it also covers the case
where someone builds spamc as `perl configure.pl && make', and it sets the
default config to ${prefix}/etc/spamc.conf. Each is set at compile time,
so spamc doesn't do any extra searching for a config file. Either method
is fine with me, and will work fine for the reason I had in mind for the
patch in the first place.
And, just to confirm, Makefile.PL doesn't need any modification.
- --sysconfdir is passed to spamc/configure during the default (perl
Makefile.PL && make) build.
Any thoughts on the Windows case? Is it easiest to not support (by
default) a config for Windows? I can't see many (if any) large Windows
installations having need for a global config file for spamc anyway.
It's a simple hack for the user to add the config file support should
they want it.
- --
Chat ya later,
John.
- --
BOFH excuse #1: clock speed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
iD8DBQFCjNqJQBw+ZtKOvTIRAiwfAJsEomqgDuIV1WZxw436Zctmt0faGwCfQcB1
Ez7RTeQm0w71nZ9Sg9evfxA=
=RxND
-----END PGP SIGNATURE-----
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
