On Sun, 24 Jul 2011, Daryl C. W. O'Shea wrote:
Was performance benchmarked before and after this change?
No, but do we care that much about performance when debug rules are turned
on?
The impact on a production install should be almost unnoticeable. When
debug of this channel is not turned on, no extra code is generated in the
compiled rule procs at all. The only overhead when this is turned off is
during generation of the compiled rule procs, where the check of the debug
flag occurs, and that only happens once when spamd is initially loaded,
correct? So there shouldn't be _any_ performance impact on a production
spamc when this isn't enabled.
(except: does "use Mumble" add non-compile-time overhead? That bit might
need to go in a config-checking if() block too, if it does...)
When it is enabled, the performance impact is minimal. I suspect the
majority is in the formatting of the output, and a possible improvement
would be a (configurable) minimum elapsed time to generate that output.
Daryl
On 23/07/2011 5:41 PM, [email protected] wrote:
Author: jhardin
Date: Sat Jul 23 21:41:27 2011
New Revision: 1150225
URL: http://svn.apache.org/viewvc?rev=1150225&view=rev
Log:
Add per-rule timing (debug "ruletimes" channel) for most rule types
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
[email protected] FALaholic #11174 pgpk -a [email protected]
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
Health Care _is_ a right - the government has no business keeping
you from getting it. But forcing somebody else to pay for your
health care at gunpoint (i.e. through taxation) is _not_ a right.
-----------------------------------------------------------------------
227 days since the first successful private orbital launch (SpaceX)