On Jul 24, 2011, at 12:04 PM, John Hardin wrote: > On Sun, 24 Jul 2011, John Hardin wrote: > >> On Sun, 24 Jul 2011, Michael Parker wrote: >> >>> How is this change different from what is provided in the >>> HitFreqsRuleTiming plugin? > > ...okay, that took about five seconds to find once I was reminded of the > name... :( > > One thing that immediately leaps out at me is that plugin uses Time::HiRes > tv_interval(), and when doing research for how best to code the elapsed time > I found benchmarks showing tv_interval() performs _much_ more poorly than > "$time1 = time(); $elapsed = time() - $time1;" The plugin might need some > performance tuning. > > The plugin is a lot heavier-weight and provides a lot more analysis than my > change. I feel my change would be a better way for an end-user to quickly > isolate a poorly-performing rule by enabling a single channel in an > interactive debug run without affecting the production install, while the > plugin provides more in-depth analysis for rule developers. > > I believe that both have a place, and I'd suggest my change is indeed > justified.
I would rather see your change implemented as a plugin, that way people can include things if they would like. All the tools are there to be able todo this, just need to make it happen. Michael > > -- > John Hardin KA7OHZ http://www.impsec.org/~jhardin/ > [email protected] FALaholic #11174 pgpk -a [email protected] > key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79 > ----------------------------------------------------------------------- > There is no doubt in my mind that millions of lives could have been > saved if the people were not "brainwashed" about gun ownership and > had been well armed. ... Gun haters always want to forget the Warsaw > Ghetto uprising, which is a perfect example of how a ragtag, > half-starved group of Jews took 10 handguns and made asses out of > the Nazis. -- Theodore Haas, Dachau survivor > ----------------------------------------------------------------------- > 227 days since the first successful private orbital launch (SpaceX)
