On Sun, 24 Jul 2011, Michael Parker wrote:
On Jul 24, 2011, at 2:55 PM, John Hardin wrote:
My change gives very basic elapsed time stats only if a specific
debugging channel is enabled. I view it as equivalent to the "rules"
debug channel logging the text that the rule matched. This sort of
thing will be regularly used by many end users when interactively
troubleshooting performance problems, and does not require any changes
to the production system's configuration (such as enabling a new
plugin).
It does however further complicate an already over complicated piece of
code.
Not all that much.
The ran_rule plugin hook was added for exactly this use case:
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=4517
As someone who has to delve into this code often enough to get sweaty
palms and the shakes when edits are mentioned I propose we stick with
the plugin call.
Okay, I'll take a look at the plugin API.
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
[email protected] FALaholic #11174 pgpk -a [email protected]
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
Watch... Wallet... Gun... Knee... -- Denny Crane
-----------------------------------------------------------------------
227 days since the first successful private orbital launch (SpaceX)
