https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6888
Bug ID: 6888
Summary: xt/60_perlcritic.t throws some errors
Product: Spamassassin
Version: 3.4 SVN branch
Hardware: PC
OS: Windows 7
Status: NEW
Severity: normal
Priority: P2
Component: Building & Packaging
Assignee: [email protected]
Reporter: [email protected]
Classification: Unclassified
Need to look into these issues.
xt/60_perlcritic....NOK 5# Failed test 'Test::Perl::Critic for
"../blib/script/sa-update"'
# at /usr/local/lib/perl5/site_perl/5.8.6/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "../blib/script/sa-update":
# Subroutine prototypes used at line 1289, column 1.
# Subroutines::ProhibitSubroutinePrototypes (Severity: 5)
# Contrary to common belief, subroutine prototypes do not enable
# compile-time checks for proper arguments. Don't use them.
xt/60_perlcritic....NOK 21# Failed test 'Test::Perl::Critic for
"../blib/lib/Mail/SpamAssassin/HTML.pm"'
# at /usr/local/lib/perl5/site_perl/5.8.6/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in
"../blib/lib/Mail/SpamAssassin/HTML.pm":
# Subroutine prototypes used at line 1046, column 1.
# Subroutines::ProhibitSubroutinePrototypes (Severity: 5)
# Contrary to common belief, subroutine prototypes do not enable
# compile-time checks for proper arguments. Don't use them.
xt/60_perlcritic....NOK 45# Failed test 'Test::Perl::Critic for
"../blib/lib/Mail/SpamAssassin/BayesStore/Redis.pm"'
# at /usr/local/lib/perl5/site_perl/5.8.6/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in
"../blib/lib/Mail/SpamAssassin/BayesStore/Redis.pm":
# Code before strictures are enabled at line 53, column 1.
# TestingAndDebugging::RequireUseStrict (Severity: 5)
# Using strictures is probably the single most effective way to improve
# the quality of your code. This policy requires that the `'use strict''
# statement must come before any other statements except `package',
# `require', and other `use' statements. Thus, all the code in the entire
# package will be affected.
#
# There are special exemptions for Moose, Moose::Role, and
# Moose::Util::TypeConstraints because they enforces strictness; e.g.
# `'use Moose'' is treated as equivalent to `'use strict''.
#
# The maximum number of violations per document for this policy defaults
# to 1.
--
You are receiving this mail because:
You are the assignee for the bug.
