https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6888
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |[email protected] Resolution|--- |FIXED --- Comment #1 from Kevin A. McGrail <[email protected]> --- (In reply to comment #0) > xt/60_perlcritic....NOK 5# Failed test 'Test::Perl::Critic for > "../blib/script/sa-update"' > # at /usr/local/lib/perl5/site_perl/5.8.6/Test/Perl/Critic.pm line 110. > # > # Perl::Critic found these violations in "../blib/script/sa-update": > # Subroutine prototypes used at line 1289, column 1. > # Subroutines::ProhibitSubroutinePrototypes (Severity: 5) > # Contrary to common belief, subroutine prototypes do not enable > # compile-time checks for proper arguments. Don't use them. > removed the () prototype on sub init_lwp > xt/60_perlcritic....NOK 21# Failed test 'Test::Perl::Critic for > "../blib/lib/Mail/SpamAssassin/HTML.pm"' > # at /usr/local/lib/perl5/site_perl/5.8.6/Test/Perl/Critic.pm line 110. > # > # Perl::Critic found these violations in > "../blib/lib/Mail/SpamAssassin/HTML.pm": > # Subroutine prototypes used at line 1046, column 1. > # Subroutines::ProhibitSubroutinePrototypes (Severity: 5) > # Contrary to common belief, subroutine prototypes do not enable > # compile-time checks for proper arguments. Don't use them. Removed the prototype on sub dec2hex > xt/60_perlcritic....NOK 45# Failed test 'Test::Perl::Critic for > "../blib/lib/Mail/SpamAssassin/BayesStore/Redis.pm"' > # at /usr/local/lib/perl5/site_perl/5.8.6/Test/Perl/Critic.pm line 110. > # > # Perl::Critic found these violations in > "../blib/lib/Mail/SpamAssassin/BayesStore/Redis.pm": > # Code before strictures are enabled at line 53, column 1. > # TestingAndDebugging::RequireUseStrict (Severity: 5) > # Using strictures is probably the single most effective way to improve > # the quality of your code. This policy requires that the `'use strict'' > # statement must come before any other statements except `package', > # `require', and other `use' statements. Thus, all the code in the entire > # package will be affected. > # > # There are special exemptions for Moose, Moose::Role, and > # Moose::Util::TypeConstraints because they enforces strictness; e.g. > # `'use Moose'' is treated as equivalent to `'use strict''. > # > # The maximum number of violations per document for this policy defaults > # to 1. Moved my $VERSION = 0.09; to below use Strict; svn commit -m 'small changes to resolve xt/60_perlcritic' lib/Mail/SpamAssassin sa-update.raw Sending lib/Mail/SpamAssassin/BayesStore/Redis.pm Sending lib/Mail/SpamAssassin/HTML.pm Sending sa-update.raw Transmitting file data ... Committed revision 1431121. -- You are receiving this mail because: You are the assignee for the bug.
