[Bug 6888] xt/60_perlcritic.t throws some errors

[bugzilla-daemon]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6888

--- Comment #2 from Mark Martinec <mark.marti...@ijs.si> ---
> removed the () prototype on sub init_lwp
> Removed the prototype on sub dec2hex

Thanks.

> lib/Mail/SpamAssassin/BayesStore/Redis.pm"'
> Moved  my $VERSION = 0.09;  to below use Strict;

The $VERSION should not be a lexically scoped ( declared by my() ).

Try:
$ cd lib/Mail/SpamAssassin/BayesStore
$ perl -le 'use Redis; print Mail::SpamAssassin::BayesStore::Redis->VERSION'
[prints nothing]

Changing declarations & assignments to @ISA and $VERSION to:

use vars qw( @ISA $VERSION );
BEGIN {
  $VERSION = 0.09;
  @ISA = qw( Mail::SpamAssassin::BayesStore );
}

yields:
$ perl -le 'use Redis; print Mail::SpamAssassin::BayesStore::Redis->VERSION'
0.09

-- 
You are receiving this mail because:
You are the assignee for the bug.