On Sun, May 15, 2022 at 10:24:46PM +0200, Michael Storz wrote:
> Well, settag supports body, rawbody, full, header and tag. It does not
> support uri, because Conf.pm has
>
> # we don't do URI evals yet - maybe later
> # if (/^uri\s+(\S+)\s+eval:(.*)$/) {
> # $self->{parser}->add_test ($1, $2, $TYPE_URI_EVALS);
> # next;
> # }
>
> and I'm using the evals for my implementation.
Ok you did not imply that before. Atleast that's better than "settag"
command, but it's still kludgy.
I don't see any advantages in it. What if you want to capture things from
"mimeheader"? The native named capture is much more versatile, I only need
to add %- check and set_tag in it's code, and then it's usable like in any
other rule. Your method can't be extended like that. Not to mention the
awkward duplication of code to iterate and regex match body amd header etc
in your plugin. In my way all the regex are already compiled by SA and
everthing happens in the standard Check.pm pipeline.
> In addition settag supports priority.
As do all rules which we can capture from..
