https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7981
--- Comment #18 from Sidney Markowitz <sid...@sidney.com> --- (In reply to Michael Storz from comment #17) > about 7987: > I'm about to go through all plugins and change the return codes. Please fill out and submit an ICLA as soon as possible, so we can be allowed to consider patches you submit. If you have already done that using an email address different than the one you are using for logging in to this Bugzilla, let us know what you used. For details on submitting an ICLA, please see https://www.apache.org/licenses/contributor-agreements.html > I now have changes for about 25 plugins. > Mostly it's the wrong code in case of a miss or after an explicit > got_hit/rule_ready a 1/0 is returned instead of an undef which leads to an > implicit got_hit/rule_ready being triggered. These changes should be > incorporated before a pre2 in my opinion. Should this be opened as a separate issue from bug #7987 ? Can 7987 be brought to a close and another issue opened that we can then decide if it needs to be fixed before pre2? > The core of the meta rule evaluation seems to work correctly. My suggestion > to change the algorithm from brute force to deterministic is more of a > (major) enhancement. It would allow run_generic_tests to be used for meta > rules as well, to improve performance by eliminating about 1,000 subroutine > calls. As a major enhancement, this part does seem like it should be in a new issue that is targeted for 4.1. > In rule_ready, however, a small semantic change must be made in my opinion. > I am in the process of making these two small changes as well and testing > the effects. Should this go into a third new issue, or is this part of the major enhancement, or is it related to the 25 plugins that you are changing to handle the return undef? > about 7992: > - Leave the new feature of Henrik in the code of SA and don't change > anything about the chaos. This choice does not preclude any other choice being done for 4.1. If what you refer to as "the chaos" does not cause known bugs, we can close bug #7992, continuing with what we have when we release pre2 and 4.0, opening a new issue for any patches that you submit to fix what you perceive as the mess. -- You are receiving this mail because: You are the assignee for the bug.
