https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8196
--- Comment #5 from Sidney Markowitz <sid...@sidney.com> --- (In reply to Henrik Krohns from comment #4) > Makefile.PL fails hard if NetAddr::IP is missing, so I think changing it > back to eval require is right solution. Nope, it is not needed. The commit I did in revision 1914036 declares NetAddr::IP as a configure dependency. CPAN installers look inside Makefile.PL to find the configure dependencies and install them if necessary before running Makefile.PL. It is ok for Makefile.PL to fail hard if the module is missing, because that's what the configure dependencies declare. Now, I'm not sure if the commit you just did is correct without also reverting the use NetAddr::IP statements that you removed in revision 1909909 What happens if the require in that one sub in Util is not executed before one of the other modules that no longer contain the use NetAddr::IP gets called? -- You are receiving this mail because: You are the assignee for the bug.
