https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8196
--- Comment #7 from Henrik Krohns <apa...@hege.li> --- (In reply to Sidney Markowitz from comment #5) > (In reply to Henrik Krohns from comment #4) > > Makefile.PL fails hard if NetAddr::IP is missing, so I think changing it > > back to eval require is right solution. > > Nope, it is not needed. > > The commit I did in revision 1914036 declares NetAddr::IP as a configure > dependency. CPAN installers look inside Makefile.PL to find the configure > dependencies and install them if necessary before running Makefile.PL. It is > ok for Makefile.PL to fail hard if the module is missing, because that's > what the configure dependencies declare. I'm not talking about cpan, but manual install: download sources, run perl Makefile.PL. It crashes immediately if Util.pm tries to load nonexisting module. $ perl Makefile.PL What email address or URL should be used in the suspected-spam report text for users who want more information on your filter installation? (In particular, ISPs should change this to a local Postmaster contact) default text: [the administrator of that system] NOTE: settings for "make test" are now controlled using "t/config.dist". See that file if you wish to customize what tests are run, and how. Can't locate NetAddr/IP.pm in @INC (you may need to install the NetAddr::IP module)....... > Now, I'm not sure if the commit you just did is correct without also > reverting the use NetAddr::IP statements that you removed in revision 1909909 > > What happens if the require in that one sub in Util is not executed before > one of the other modules that no longer contain the use NetAddr::IP gets > called? The require is not in any sub. All the other modules load Util.pm which immediately loads NetAddr::IP. Is there a scenario where it wouldn't be executed first? -- You are receiving this mail because: You are the assignee for the bug.
