> On 2012-03-29 05:41:04, Cheolsoo Park wrote: > > Hello Masatake, I have a quick question about your patch. > > > > Since you're adding new tests to test/com/cloudera/sqoop/manager, "ant test > > -Dthirdparty=true" will fail unless the test requirements are not installed > > (PostgreSql 9.1, pg_bulkload 3.1, etc). > > > > I think that you can do either: > > > > 1) Not run your tests with "ant test -Dthirdparty=true". > > > > or > > > > 2) Update the wiki page and user doc for setting up development env. > > > > But since your tests are for a specific connector, I think that #1 makes > > more sense. Please let me know what you think. > > > > Thanks, > > Cheolsoo > > Masatake Iwasaki wrote: > Hello Cheolsoo, > I think it is not necessary to run the test in -Dthirdparty=true case. > Renaming the test case class to *ManualTest is reasonable way to do so? > > Because there is already descrption for setting up PostgreSQL, updating > user doc for developper is also possible. > A few addition make it.
Hi Masatake, Indeed, renaming the test case to *ManualTest does the trick. Would you mind making that change to your patch? I am no committer so my review doesn't really matter. But I am going to try out your patch out of curiosity. :-) Thanks, Cheolsoo - Cheolsoo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review6510 ----------------------------------------------------------- On 2012-01-13 05:23:36, Masatake Iwasaki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2724/ > ----------------------------------------------------------- > > (Updated 2012-01-13 05:23:36) > > > Review request for Sqoop. > > > Summary > ------- > > Patch for SQOOP-390 > https://issues.apache.org/jira/browse/SQOOP-390 > > > This addresses bug SQOOP-390. > https://issues.apache.org/jira/browse/SQOOP-390 > > > Diffs > ----- > > /src/java/com/cloudera/sqoop/manager/PGBulkloadManager.java PRE-CREATION > /src/java/com/cloudera/sqoop/mapreduce/AutoProgressReducer.java > PRE-CREATION > /src/java/com/cloudera/sqoop/mapreduce/PGBulkloadExportJob.java > PRE-CREATION > /src/java/com/cloudera/sqoop/mapreduce/PGBulkloadExportMapper.java > PRE-CREATION > /src/java/com/cloudera/sqoop/mapreduce/PGBulkloadExportReducer.java > PRE-CREATION > /src/test/com/cloudera/sqoop/manager/PGBulkloadManagerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2724/diff > > > Testing > ------- > > This patch include the test class PGBulkloadManagerTest. > I've tested "ant test" and passed. > > > Thanks, > > Masatake > >
