> On July 26, 2012, 9:13 p.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java, lines 215-216 > > <https://reviews.apache.org/r/2724/diff/3/?file=129305#file129305line215> > > > > I personally do not like this table searching. We might delete some > > tables that user left there intentionally from previous export. I would > > more prefer to simply not support --clear-staging-table parameter (properly > > die if it will be specified and document this feature in the user guide). > > What do you think?
I agree that deleting table based name pattern is unsafe and unpredictable. I will disable --clear-staging-table option. - Masatake ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review9514 ----------------------------------------------------------- On July 26, 2012, 10:41 a.m., Masatake Iwasaki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2724/ > ----------------------------------------------------------- > > (Updated July 26, 2012, 10:41 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > Patch for SQOOP-390 > https://issues.apache.org/jira/browse/SQOOP-390 > > > This addresses bug SQOOP-390. > https://issues.apache.org/jira/browse/SQOOP-390 > > > Diffs > ----- > > /src/java/org/apache/sqoop/manager/PGBulkloadManager.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/AutoProgressReducer.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java > PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java > PRE-CREATION > /src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2724/diff/ > > > Testing > ------- > > This patch include the test class PGBulkloadManagerTest. > I've tested "ant test" and passed. > > > Thanks, > > Masatake Iwasaki > >
