----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review10415 -----------------------------------------------------------
Thank you sir for your updated patch. I believe we're almost at the end. I just have two additional notes: /src/docs/user/connectors.txt <https://reviews.apache.org/r/2724/#comment22189> Nit: Please remove the white space character at the end of the line /src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java <https://reviews.apache.org/r/2724/#comment22190> My compiler is complaining here that this method do not override or implement method from a super type. This method do not seem to be used anywhere, so I'm wondering if we need it? I believe that I'll be able to commit your patch once you will fix those! Jarcec - Jarek Cecho On Aug. 15, 2012, 6:14 p.m., Masatake Iwasaki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2724/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2012, 6:14 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Patch for SQOOP-390 > https://issues.apache.org/jira/browse/SQOOP-390 > > > This addresses bug SQOOP-390. > https://issues.apache.org/jira/browse/SQOOP-390 > > > Diffs > ----- > > /src/docs/user/SqoopUserGuide.txt 1367974 > /src/docs/user/connectors.txt PRE-CREATION > /src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java 1367974 > /src/java/org/apache/sqoop/manager/PGBulkloadManager.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/AutoProgressMapper.java 1367974 > /src/java/org/apache/sqoop/mapreduce/AutoProgressReducer.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java > PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java > PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/ProgressThread.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/SqoopReducer.java PRE-CREATION > /src/java/org/apache/sqoop/util/PostgreSQLUtils.java PRE-CREATION > /src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2724/diff/ > > > Testing > ------- > > This patch include the test class PGBulkloadManagerTest. > I've tested "ant test" and passed. > > > Thanks, > > Masatake Iwasaki > >
