> On Aug. 9, 2012, 7:08 a.m., Jarek Cecho wrote: > > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java, lines > > 85-90 > > <https://reviews.apache.org/r/2724/diff/4/?file=134267#file134267line85> > > > > I'm thinking here - is there a situation where the table will exists > > when you're using unique task id as a part of table name? (except the case > > where user will actually have such weirdly named table)
I think it is rare situation in real clusters but mapreduce job run in local mode creates same task attempt name every time. Clearing staging table is useful at least for ant tests. - Masatake ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2724/#review10059 ----------------------------------------------------------- On Aug. 15, 2012, 6:14 p.m., Masatake Iwasaki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2724/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2012, 6:14 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Patch for SQOOP-390 > https://issues.apache.org/jira/browse/SQOOP-390 > > > This addresses bug SQOOP-390. > https://issues.apache.org/jira/browse/SQOOP-390 > > > Diffs > ----- > > /src/docs/user/SqoopUserGuide.txt 1367974 > /src/docs/user/connectors.txt PRE-CREATION > /src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java 1367974 > /src/java/org/apache/sqoop/manager/PGBulkloadManager.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/AutoProgressMapper.java 1367974 > /src/java/org/apache/sqoop/mapreduce/AutoProgressReducer.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java > PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java > PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/ProgressThread.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/SqoopReducer.java PRE-CREATION > /src/java/org/apache/sqoop/util/PostgreSQLUtils.java PRE-CREATION > /src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2724/diff/ > > > Testing > ------- > > This patch include the test class PGBulkloadManagerTest. > I've tested "ant test" and passed. > > > Thanks, > > Masatake Iwasaki > >
