-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2724/
-----------------------------------------------------------

(Updated Aug. 5, 2012, 6:56 p.m.)


Review request for Sqoop.


Changes
-------

1. got ProgressThread out of AutoProgressMapper and use it from both of 
AutoProgress[Mapper|Reducer] to remove duplicate code.
2. moved clearing of staging table to each map tasks and got rid of deletion 
based on table name patten matching.
3. made the number of reduce tasks configurable by mapred.reduce.tasks property.
4. made tablespace for staging table configurable by 
pgbulkload.staging.tablespace property.
5. added testcase for export with multi reduce tasks.
6. fixed some log messages and comments.


Description
-------

Patch for SQOOP-390
https://issues.apache.org/jira/browse/SQOOP-390


This addresses bug SQOOP-390.
    https://issues.apache.org/jira/browse/SQOOP-390


Diffs (updated)
-----

  /src/java/org/apache/sqoop/manager/PGBulkloadManager.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/AutoProgressMapper.java 1367974 
  /src/java/org/apache/sqoop/mapreduce/AutoProgressReducer.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java 
PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/ProgressThread.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/SqoopReducer.java PRE-CREATION 
  /src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/2724/diff/


Testing
-------

This patch include the test class PGBulkloadManagerTest.
I've tested "ant test" and passed.


Thanks,

Masatake Iwasaki

Reply via email to