> On June 13, 2013, 1:41 a.m., Abraham Elmahrek wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java, > > line 513 > > <https://reviews.apache.org/r/11537/diff/2-4/?file=299088#file299088line513> > > > > UTF-16 should support 0 to 0x10FFFF code points.
Good point Abrahama. Actually the codepoint handling was onething I was not comfortable with that I discussed earlier with Jarek offline. Using a large base will cause more rounding errors and repeating fractions towards higher fractional positions. But I decided not to stay with 2^16 but as you noted, it does not cover the supplementary characters. As you know, Java stores UTF16 as one or two char values depending on whether is in BMP plane or supplementary plane. But iterating through the Java strings is in char boundaries. I found another issue in that area. I fixed that issue also, but we have to enhance this more in the future. - Venkat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11537/#review21827 ----------------------------------------------------------- On June 12, 2013, 5:23 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11537/ > ----------------------------------------------------------- > > (Updated June 12, 2013, 5:23 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > This addresses Boolean, date, time, and timestamp splitters. > > THis also disallows char type splitters as discussed in SQOOP-976 > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java > f80f30d > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java > ee314d0 > > Diff: https://reviews.apache.org/r/11537/diff/ > > > Testing > ------- > > Introduced new unit tests to test new functionality > All tests pass > > > Thanks, > > Venkat Ranganathan > >
