----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11537/#review21867 -----------------------------------------------------------
Ship it! Looks good to me! connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java <https://reviews.apache.org/r/11537/#comment45167> Seems right. Nit: 2097152 can be represented as a hex literal: 0x200000. Might be easier to see. - Abraham Elmahrek On June 13, 2013, 5:46 a.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11537/ > ----------------------------------------------------------- > > (Updated June 13, 2013, 5:46 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > This addresses Boolean, date, time, and timestamp splitters. > > THis also disallows char type splitters as discussed in SQOOP-976 > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java > f80f30d > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java > ee314d0 > > Diff: https://reviews.apache.org/r/11537/diff/ > > > Testing > ------- > > Introduced new unit tests to test new functionality > All tests pass > > > Thanks, > > Venkat Ranganathan > >
