-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11537/
-----------------------------------------------------------

(Updated June 13, 2013, 5:46 a.m.)


Review request for Sqoop.


Changes
-------

Fixed the base in coverstion to a large enough value to allow for all possible 
Unicode code points.   Fixed iterating through the String to properly handle 
codepoints


Description
-------

This addresses Boolean, date, time, and timestamp splitters.

THis also disallows char type splitters as discussed in SQOOP-976


Diffs (updated)
-----

  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
 f80f30d 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
 ee314d0 

Diff: https://reviews.apache.org/r/11537/diff/


Testing
-------

Introduced new unit tests to test new functionality
All tests pass


Thanks,

Venkat Ranganathan

Reply via email to