----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25636/#review53395 -----------------------------------------------------------
In general +1. Would you mind adding a test case to verify this functionality or creating a follow up Jira for this? src/java/org/apache/sqoop/ConnFactory.java <https://reviews.apache.org/r/25636/#comment93046> It seems like fileNames cannot be null? http://docs.oracle.com/javase/7/docs/api/java/io/File.html#list() - Abraham Elmahrek On Sept. 15, 2014, 8:21 a.m., Chiwan Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25636/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 8:21 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1387 > https://issues.apache.org/jira/browse/SQOOP-1387 > > > Repository: sqoop-trunk > > > Description > ------- > > I fixed a bug reported in SQOOP-1387. After applying this patch, Sqoop will > log some warning messages when there is no permission on managers.d directory. > > > Diffs > ----- > > src/java/org/apache/sqoop/ConnFactory.java e9c45bc > > Diff: https://reviews.apache.org/r/25636/diff/ > > > Testing > ------- > > Tested on test cluster using (1.4.6-SNAPSHOT) with no permission on > managers.d directory. > > > Thanks, > > Chiwan Park > >
