----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25636/#review53604 -----------------------------------------------------------
Ship it! Looks good except for the nit below! src/java/org/apache/sqoop/ConnFactory.java <https://reviews.apache.org/r/25636/#comment93311> NIT: I think "for" is incorrect here. What about: "Sqoop cannot load managers from the configuration directory. Please check the permissions on your $SQOOP_CONF_DIR/managers.d directory.". Or something similar... - Abraham Elmahrek On Sept. 16, 2014, 8:32 a.m., Chiwan Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25636/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 8:32 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1387 > https://issues.apache.org/jira/browse/SQOOP-1387 > > > Repository: sqoop-trunk > > > Description > ------- > > I fixed a bug reported in SQOOP-1387. After applying this patch, Sqoop will > log some warning messages when there is no permission on managers.d directory. > > > Diffs > ----- > > src/java/org/apache/sqoop/ConnFactory.java e9c45bc > > Diff: https://reviews.apache.org/r/25636/diff/ > > > Testing > ------- > > Tested on test cluster using (1.4.6-SNAPSHOT) with no permission on > managers.d directory. > > > Thanks, > > Chiwan Park > >
