----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25636/#review53495 -----------------------------------------------------------
src/java/org/apache/sqoop/ConnFactory.java <https://reviews.apache.org/r/25636/#comment93169> You've added two warnings, but the text are identicial. Consider either use more accurate words to describe the warnings or handle both cases together. try { filenames = mgrDir.list(); } catch (SecurityException e) { filenames = null; } if (null == filenames) { LOG.warn(...); return conf; } - Qian Xu On Sept. 15, 2014, 4:21 p.m., Chiwan Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25636/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 4:21 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1387 > https://issues.apache.org/jira/browse/SQOOP-1387 > > > Repository: sqoop-trunk > > > Description > ------- > > I fixed a bug reported in SQOOP-1387. After applying this patch, Sqoop will > log some warning messages when there is no permission on managers.d directory. > > > Diffs > ----- > > src/java/org/apache/sqoop/ConnFactory.java e9c45bc > > Diff: https://reviews.apache.org/r/25636/diff/ > > > Testing > ------- > > Tested on test cluster using (1.4.6-SNAPSHOT) with no permission on > managers.d directory. > > > Thanks, > > Chiwan Park > >
