> On Nov. 17, 2014, 12:09 a.m., Qian Xu wrote:
> > common/src/main/java/org/apache/sqoop/schema/type/Enum.java, line 77
> > <https://reviews.apache.org/r/28110/diff/2/?file=765521#file765521line77>
> >
> > NITS: I'd always use brackets just to be safe. Sometimes after merge or
> > rebase, code will be broken. The famous SSL heartbleeding is a lesson for
> > us all to learn.
I tried the IDE generated one. did not add bracket:)
@Override
public boolean equals(Object obj) {
if (this == obj)
return true;
if (!super.equals(obj))
return false;
if (getClass() != obj.getClass())
return false;
Enum other = (Enum) obj;
if (options == null) {
if (other.options != null)
return false;
} else if (!options.equals(other.options))
return false;
return true;
}
@Override
public int hashCode() {
final int prime = 31;
int result = super.hashCode();
result = prime * result + ((options == null) ? 0 : options.hashCode());
return result;
}
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28110/#review61699
-----------------------------------------------------------
On Nov. 16, 2014, 4:48 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28110/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2014, 4:48 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1716
> https://issues.apache.org/jira/browse/SQOOP-1716
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java
> dec8c0e
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java 1388d49
>
> common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java
> 9f8ee3e
>
> Diff: https://reviews.apache.org/r/28110/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
