----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28110/#review62002 -----------------------------------------------------------
Ship it! Looks good. common/src/main/java/org/apache/sqoop/schema/type/Enum.java <https://reviews.apache.org/r/28110/#comment103928> Interesting. Google had this library with preconditions as well. Good thinking. common/src/main/java/org/apache/sqoop/schema/type/Enum.java <https://reviews.apache.org/r/28110/#comment103930> Add tests for validate new logic? - Abraham Elmahrek On Nov. 18, 2014, 6:56 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28110/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 6:56 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1716 > https://issues.apache.org/jira/browse/SQOOP-1716 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > dec8c0e > common/src/main/java/org/apache/sqoop/schema/type/Enum.java 1388d49 > > common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java > 9f8ee3e > > Diff: https://reviews.apache.org/r/28110/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
