----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28537/#review63297 -----------------------------------------------------------
I have one major question that is highlighled below in the Test. It seems that we are not creating proper object representation of trully nested data types, as the "Map<String, Array<String>> will expect (and return) Map<String, String>. I'm wondering if this is intentional or not? connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java <https://reviews.apache.org/r/28537/#comment105457> Can we please not rearange imports as part of this patch? connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java <https://reviews.apache.org/r/28537/#comment105458> Since the Map's value is Array of Text, I would expect that we put here Array of Strings, rather then one String that represents serialized Array. Jarcec - Jarek Cecho On Nov. 29, 2014, 8:40 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28537/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2014, 8:40 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1750 > https://issues.apache.org/jira/browse/SQOOP-1750 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > 4f2baf9 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > b629897 > > Diff: https://reviews.apache.org/r/28537/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
