> On Nov. 29, 2014, 1:57 p.m., Jarek Cecho wrote:
> > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java,
> > line 607
> > <https://reviews.apache.org/r/28537/diff/1/?file=778388#file778388line607>
> >
> > Since the Map's value is Array of Text, I would expect that we put here
> > Array of Strings, rather then one String that represents serialized Array.
schema.addColumn(new org.apache.sqoop.schema.type.Map("1", new Text("key"), new
Array("value", new FixedPoint("number"))));
> On Nov. 29, 2014, 1:57 p.m., Jarek Cecho wrote:
> > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java,
> > lines 21-52
> > <https://reviews.apache.org/r/28537/diff/1/?file=778388#file778388line21>
> >
> > Can we please not rearange imports as part of this patch?
Let me highlight one thing.
there needs to be a standard we follow in all files.
In the CSVIntermediateDataFormat. the order is:
com
org
java
javax
I put this in the "IDE" fomratter.
the test file has some other random order. we cannot have this, it is super in
productive, if you want this to continue, lets stop been anal about such a
trivial thing.
My 2 cents, it would be good for the project to have a standardized order when
I import new things, I use a shortcut in IDE and let the formatter take care of
it.
I dont manually type in every new import, that is not my good use of time.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28537/#review63297
-----------------------------------------------------------
On Nov. 29, 2014, 12:40 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28537/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2014, 12:40 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1750
> https://issues.apache.org/jira/browse/SQOOP-1750
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
> 4f2baf9
>
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
> b629897
>
> Diff: https://reviews.apache.org/r/28537/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
