> On Nov. 29, 2014, 1:57 p.m., Jarek Cecho wrote: > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java, > > line 607 > > <https://reviews.apache.org/r/28537/diff/1/?file=778388#file778388line607> > > > > Since the Map's value is Array of Text, I would expect that we put here > > Array of Strings, rather then one String that represents serialized Array. > > Veena Basavaraj wrote: > schema.addColumn(new org.apache.sqoop.schema.type.Map("1", new > Text("key"), new Array("value", new FixedPoint("number"))));
fixed, all caught another issue while fixing this, added a test case for it. - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28537/#review63297 ----------------------------------------------------------- On Nov. 29, 2014, 3:09 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28537/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2014, 3:09 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1750 > https://issues.apache.org/jira/browse/SQOOP-1750 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > 4f2baf9 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > b629897 > > Diff: https://reviews.apache.org/r/28537/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
