> On Dec. 12, 2014, 8:51 a.m., Abraham Elmahrek wrote: > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java, > > lines 416-422 > > <https://reviews.apache.org/r/28999/diff/1/?file=790208#file790208line416> > > > > Why not check for null values in encodeCSVStringElements?
just avoid the duplicate code in every place. it does it in one place now for all the types. > On Dec. 12, 2014, 8:51 a.m., Abraham Elmahrek wrote: > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java, > > lines 478-535 > > <https://reviews.apache.org/r/28999/diff/1/?file=790208#file790208line478> > > > > This seems like a lot of work for what seems like a null check? not sure what you mean by this comments. All it does is this. We chak a value is null in the object Array and then record those indices, we do not process them while converin it to a string. > On Dec. 12, 2014, 8:51 a.m., Abraham Elmahrek wrote: > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java, > > lines 419-420 > > <https://reviews.apache.org/r/28999/diff/1/?file=790208#file790208line419> > > > > In an object array, what's wrong with real null? Please read the spec and the tests should answer it. if a object is null, then in the CSV string we ill have NULL if we have a value as NULL, then there is no need ot process it futher for escaping - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28999/#review64916 ----------------------------------------------------------- On Dec. 12, 2014, 8:35 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28999/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 8:35 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1825 > https://issues.apache.org/jira/browse/SQOOP-1825 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > fe4cdd7 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > 2376d4a > > Diff: https://reviews.apache.org/r/28999/diff/ > > > Testing > ------- > > yes, have unit tests as well > > > Thanks, > > Veena Basavaraj > >
