----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28999/#review64926 -----------------------------------------------------------
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java <https://reviews.apache.org/r/28999/#comment107763> This seems to be used only in setObjectData. If the data changes, the contents of this array will change. Should this be a local variable in setObjectData? Also, maybe a Set is better since we're doing mostly "exists" look ups. - Abraham Elmahrek On Dec. 12, 2014, 4:35 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28999/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 4:35 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1825 > https://issues.apache.org/jira/browse/SQOOP-1825 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > fe4cdd7 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > 2376d4a > > Diff: https://reviews.apache.org/r/28999/diff/ > > > Testing > ------- > > yes, have unit tests as well > > > Thanks, > > Veena Basavaraj > >
