> On Dec. 12, 2014, 9:12 a.m., Abraham Elmahrek wrote: > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java, > > line 102 > > <https://reviews.apache.org/r/28999/diff/1/?file=790208#file790208line102> > > > > This seems to be used only in setObjectData. If the data changes, the > > contents of this array will change. Should this be a local variable in > > setObjectData? > > > > Also, maybe a Set is better since we're doing mostly "exists" look ups.
sure set makes sense. it is used in 2 methods, so I kept it in the class, there are already tons of other state objects that manintain indices per column type - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28999/#review64926 ----------------------------------------------------------- On Dec. 12, 2014, 8:35 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28999/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 8:35 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1825 > https://issues.apache.org/jira/browse/SQOOP-1825 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > fe4cdd7 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > 2376d4a > > Diff: https://reviews.apache.org/r/28999/diff/ > > > Testing > ------- > > yes, have unit tests as well > > > Thanks, > > Veena Basavaraj > >
