-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29319/#review65819
-----------------------------------------------------------
LGTM. Unit tests are failing for me though.
testSqoopMapper(org.apache.sqoop.job.TestMapReduce) Time elapsed: 27.716 sec
<<< FAILURE!
java.lang.AssertionError: Job failed! expected:<true> but was:<false>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at
org.apache.sqoop.job.TestMapReduce.testSqoopMapper(TestMapReduce.java:102)
testNullOutputFormat(org.apache.sqoop.job.TestMapReduce) Time elapsed: 11.342
sec <<< FAILURE!
java.lang.AssertionError: Job failed! expected:<true> but was:<false>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at
org.apache.sqoop.job.TestMapReduce.testNullOutputFormat(TestMapReduce.java:124)
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
<https://reviews.apache.org/r/29319/#comment109057>
Realizing where the issues are more and more. There are multiple ways to
get data and write data.
- Abraham Elmahrek
On Dec. 22, 2014, 5:51 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29319/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2014, 5:51 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1935
> https://issues.apache.org/jira/browse/SQOOP-1935
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
>
> execution/mapreduce/src/main/java/org/apache/sqoop/job/io/SqoopWritable.java
> 6a0bfa4
>
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
> aaf771c
>
> execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestSqoopWritable.java
> b07a076
>
> Diff: https://reviews.apache.org/r/29319/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
