> On Dec. 22, 2014, 1:11 p.m., Abraham Elmahrek wrote: > > LGTM. Unit tests are failing for me though. > > testSqoopMapper(org.apache.sqoop.job.TestMapReduce) Time elapsed: 27.716 > > sec <<< FAILURE! > > java.lang.AssertionError: Job failed! expected:<true> but was:<false> > > at org.junit.Assert.fail(Assert.java:88) > > at org.junit.Assert.failNotEquals(Assert.java:743) > > at org.junit.Assert.assertEquals(Assert.java:118) > > at > > org.apache.sqoop.job.TestMapReduce.testSqoopMapper(TestMapReduce.java:102) > > > > testNullOutputFormat(org.apache.sqoop.job.TestMapReduce) Time elapsed: > > 11.342 sec <<< FAILURE! > > java.lang.AssertionError: Job failed! expected:<true> but was:<false> > > at org.junit.Assert.fail(Assert.java:88) > > at org.junit.Assert.failNotEquals(Assert.java:743) > > at org.junit.Assert.assertEquals(Assert.java:118) > > at > > org.apache.sqoop.job.TestMapReduce.testNullOutputFormat(TestMapReduce.java:124)
yes uploading the fix. I should have run all tests, > On Dec. 22, 2014, 1:11 p.m., Abraham Elmahrek wrote: > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java, > > line 105 > > <https://reviews.apache.org/r/29319/diff/2/?file=798777#file798777line105> > > > > Realizing where the issues are more and more. There are multiple ways > > to get data and write data. yeah you are right, so I removed this, let me know what your thoughts are if I have mis understood it. - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29319/#review65819 ----------------------------------------------------------- On Dec. 22, 2014, 9:51 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29319/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2014, 9:51 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1935 > https://issues.apache.org/jira/browse/SQOOP-1935 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > execution/mapreduce/src/main/java/org/apache/sqoop/job/io/SqoopWritable.java > 6a0bfa4 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > aaf771c > > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestSqoopWritable.java > b07a076 > > Diff: https://reviews.apache.org/r/29319/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
