> On Dec. 23, 2014, 7:16 a.m., Qian Xu wrote: > > execution/mapreduce/src/main/java/org/apache/sqoop/job/io/SqoopWritable.java, > > line 52 > > <https://reviews.apache.org/r/29319/diff/3/?file=798942#file798942line52> > > > > 1. @VisibleForTesting is equivalent to the comment. I use it > > everywhere. Do you mind to use it to keep them consistent? > > 2. If the class is immutable, I'd suggest to create a testing visible > > consctructor `SqoopWritable(IntermediateDataFormat<?> dataFormat, String > > data)`.
Create follow ups for the VisibleForTesting annotation? - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29319/#review65879 ----------------------------------------------------------- On Dec. 22, 2014, 10:33 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29319/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2014, 10:33 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1935 > https://issues.apache.org/jira/browse/SQOOP-1935 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > execution/mapreduce/src/main/java/org/apache/sqoop/job/io/SqoopWritable.java > 6a0bfa4 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > aaf771c > > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestSqoopWritable.java > b07a076 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/util/MRJobTestUtil.java > 5d5359e > > Diff: https://reviews.apache.org/r/29319/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
