[
https://issues.apache.org/jira/browse/SQOOP-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275369#comment-14275369
]
Veena Basavaraj commented on SQOOP-1988:
----------------------------------------
patch looks ok, I would still adk [~gwenshap] to take a peek since a lot of
this code in LocationMatcher/ Name and its tests were added.
I would also add some test cases to make sure if there are nulls during
matching, it is left as it is.
> Sqoop2: isNull handling should be moved to CSVIntermediateDataFormat
> --------------------------------------------------------------------
>
> Key: SQOOP-1988
> URL: https://issues.apache.org/jira/browse/SQOOP-1988
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Qian Xu
> Assignee: Qian Xu
> Fix For: 2.0.0
>
> Attachments: SQOOP-1988.patch
>
>
> The {{Matcher.getMatchingData}} method is expected to rearrange record fields
> according to the FROM and TO schema. Currently here is an extra step in the
> implementation, which will reset any {{null}} {{"NULL"}} {{"null"}}
> {{"'null'"}} or {{""}} field to null.
> As there is no comment or documentation about this, I guess it is some
> undocumented special handling. [Here is some
> discussion|https://issues.apache.org/jira/browse/SQOOP-1811?focusedCommentId=14270755&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14270755].
> I think this check should not belong here. I propose to remove it. As the
> method will be called very frequently, the code removal will have performance
> advance. Thanks [~jerrychenhf]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
