[
https://issues.apache.org/jira/browse/SQOOP-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288884#comment-14288884
]
Sqoop QA bot commented on SQOOP-1988:
-------------------------------------
Testing file
[SQOOP-1988.3.patch|https://issues.apache.org/jira/secure/attachment/12694096/SQOOP-1988.3.patch]
against branch sqoop2 took 0:37:23.256909.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed
{color:green}SUCCESS:{color} All integration tests passed
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/984/console].
This message is automatically generated.
> Sqoop2: isNull handling should be moved to CSVIntermediateDataFormat
> --------------------------------------------------------------------
>
> Key: SQOOP-1988
> URL: https://issues.apache.org/jira/browse/SQOOP-1988
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Qian Xu
> Assignee: Qian Xu
> Fix For: 1.99.5
>
> Attachments: SQOOP-1988.3.patch, SQOOP-1988.patch
>
>
> The {{Matcher.getMatchingData}} method is expected to rearrange record fields
> according to the FROM and TO schema. Currently here is an extra step in the
> implementation, which will reset any {{null}} {{"NULL"}} {{"null"}}
> {{"'null'"}} or {{""}} field to null.
> As there is no comment or documentation about this, I guess it is some
> undocumented special handling. [Here is some
> discussion|https://issues.apache.org/jira/browse/SQOOP-1811?focusedCommentId=14270755&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14270755].
> I think this check should not belong here. I propose to remove it. As the
> method will be called very frequently, the code removal will have performance
> advance. Thanks [~jerrychenhf]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
