> On Jan. 22, 2015, 10:32 p.m., Veena Basavaraj wrote:
> > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java,
> > line 63
> > <https://reviews.apache.org/r/29849/diff/4/?file=831586#file831586line63>
> >
> > can we remove fromColNameIndexMap variable
> >
> > getFromSchema().getColumnNameIndex(toCol.getName()))
its ok we can remoe this another rb
fromColNameIndexMap = new HashMap<String, Integer>();
int fromIndex = 0;
for (Column fromCol : getFromSchema().getColumnsList()) {
fromColNameIndexMap.put(fromCol.getName(), fromIndex);
fromIndex++;
}
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29849/#review69353
-----------------------------------------------------------
On Jan. 22, 2015, 10:28 p.m., Qian Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29849/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2015, 10:28 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1988
> https://issues.apache.org/jira/browse/SQOOP-1988
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java
> 10772d9
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java
> 899f734
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java
> 365cb87
>
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestLocationMatcher.java
> f23694d
>
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestNameMatcher.java
> 742a35c
>
> Diff: https://reviews.apache.org/r/29849/diff/
>
>
> Testing
> -------
>
> Existing tests passed
>
>
> Thanks,
>
> Qian Xu
>
>
