----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29849/#review69353 -----------------------------------------------------------
Ship it! connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java <https://reviews.apache.org/r/29849/#comment114031> can we remove fromColNameIndexMap variable getFromSchema().getColumnNameIndex(toCol.getName())) - Veena Basavaraj On Jan. 22, 2015, 10:28 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29849/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 10:28 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1988 > https://issues.apache.org/jira/browse/SQOOP-1988 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java > 10772d9 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > 899f734 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java > 365cb87 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestLocationMatcher.java > f23694d > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestNameMatcher.java > 742a35c > > Diff: https://reviews.apache.org/r/29849/diff/ > > > Testing > ------- > > Existing tests passed > > > Thanks, > > Qian Xu > >
