----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29849/#review67879 -----------------------------------------------------------
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherError.java <https://reviews.apache.org/r/29849/#comment111972> pleae clean up 0000 if it is not used I am not sure why we need the 0001 checks since MatcherFactory instantiates these matchers after doing the right check connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java <https://reviews.apache.org/r/29849/#comment111973> I am not sure you got the point I mentioned, if you see the MatcherFactory code, it already does the empty check, so why need this check here? in that case Name matcher needs both from and to, so why only to is checked, As I said above this whole 0001 check is not even required - Veena Basavaraj On Jan. 13, 2015, 8:13 a.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29849/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 8:13 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1988 > https://issues.apache.org/jira/browse/SQOOP-1988 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java > d92723e > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > 36ac5a5 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherError.java > 577b091 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java > 7cbc39f > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestLocationMatcher.java > 624fa7b > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestNameMatcher.java > 76ff0da > > Diff: https://reviews.apache.org/r/29849/diff/ > > > Testing > ------- > > Existing tests passed > > > Thanks, > > Qian Xu > >
