----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30979/#review72417 -----------------------------------------------------------
A couple of extra thoughts: 1. Indentation changes don't seem necessary 2. I don't see privileges being created when we create a new job or link? core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java <https://reviews.apache.org/r/30979/#comment118477> I'd move this check higher up into the request handlers so that the Repositories can worry about purely databases. core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java <https://reviews.apache.org/r/30979/#comment118479> Ditto core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java <https://reviews.apache.org/r/30979/#comment118478> Same as above core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java <https://reviews.apache.org/r/30979/#comment118480> Ditto core/src/main/java/org/apache/sqoop/security/SecurityConstants.java <https://reviews.apache.org/r/30979/#comment118475> Some of the indentation changes seem unnecessary server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java <https://reviews.apache.org/r/30979/#comment118476> Some of the indentation changes here are unnecessary - Abraham Elmahrek On Feb. 13, 2015, 7:23 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30979/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 7:23 a.m.) > > > Review request for Sqoop and shen guoquan. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > If the resource is updated, such as rename the job, post-function should be > called to inform RBAC to update resource as well. > Move constants "Resource Type" and "Role Type" into SecurityConstants.java > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java > 091c3ca784901c247b4093f43e2170b7dcdfcbe6 > core/src/main/java/org/apache/sqoop/security/SecurityConstants.java > fde6b60432f270195262def26a6bef8ae9df601b > > security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java > bb1ce3b741087d505350777dc23e6d7f1af53577 > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java > 41a8b95d74ff1cd3efcb00c6af593e3f9ffba2bf > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > f3f8c53b6d5568d0477a76ee0ca72c3eb8237b71 > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > 7041c2dcab1ea829ed377978dde51e74acf5dcf1 > > Diff: https://reviews.apache.org/r/30979/diff/ > > > Testing > ------- > > local > > > Thanks, > > richard zhou > >
