> On Feb. 13, 2015, 7:10 p.m., Abraham Elmahrek wrote: > > A couple of extra thoughts: > > 1. Indentation changes don't seem necessary > > 2. I don't see privileges being created when we create a new job or link?
There is no auto-privilege created when creating a new job or link. Whenever a new job or link is created, the admin need to grant privilege manually. - richard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30979/#review72417 ----------------------------------------------------------- On Feb. 15, 2015, 7:06 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30979/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2015, 7:06 a.m.) > > > Review request for Sqoop and shen guoquan. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > If the resource is updated, such as rename the job, post-function should be > called to inform RBAC to update resource as well. > Move constants "Resource Type" and "Role Type" into SecurityConstants.java > > > Diffs > ----- > > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > f3f8c53b6d5568d0477a76ee0ca72c3eb8237b71 > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > 7041c2dcab1ea829ed377978dde51e74acf5dcf1 > > Diff: https://reviews.apache.org/r/30979/diff/ > > > Testing > ------- > > local > > > Thanks, > > richard zhou > >
