----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30979/ -----------------------------------------------------------
(Updated Feb. 15, 2015, 7:06 a.m.) Review request for Sqoop and shen guoquan. Changes ------- 1. Move drop resource function out of the transaction, like hive. 2. Since persistence id will not changed, the update resource function seems un-necessary now. If the resource name changed to use job/link name, then the updated resource function needs to be added in. Repository: sqoop-sqoop2 Description ------- If the resource is updated, such as rename the job, post-function should be called to inform RBAC to update resource as well. Move constants "Resource Type" and "Role Type" into SecurityConstants.java Diffs (updated) ----- server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java f3f8c53b6d5568d0477a76ee0ca72c3eb8237b71 server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 7041c2dcab1ea829ed377978dde51e74acf5dcf1 Diff: https://reviews.apache.org/r/30979/diff/ Testing ------- local Thanks, richard zhou
