----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37672/#review96082 -----------------------------------------------------------
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java (line 94) <https://reviews.apache.org/r/37672/#comment151289> Charset.defaultCharset() execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java (line 99) <https://reviews.apache.org/r/37672/#comment151290> Charset.defaultCharset() execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java (line 114) <https://reviews.apache.org/r/37672/#comment151291> Charset.defaultCharset() execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java (line 119) <https://reviews.apache.org/r/37672/#comment151293> Charset.defaultCharset() execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java (line 133) <https://reviews.apache.org/r/37672/#comment151292> Charset.defaultCharset() execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java (line 147) <https://reviews.apache.org/r/37672/#comment151294> Charset.defaultCharset() execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java (line 150) <https://reviews.apache.org/r/37672/#comment151295> Charset.defaultCharset() execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java (line 237) <https://reviews.apache.org/r/37672/#comment151296> Charset.defaultCharset() execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java (line 257) <https://reviews.apache.org/r/37672/#comment151297> Charset.defaultCharset() execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java (line 58) <https://reviews.apache.org/r/37672/#comment151298> Private as well. execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java (line 76) <https://reviews.apache.org/r/37672/#comment151299> Might not be necessary if we create a constructor that consumes a partition? Also, error handling is missing. - Abraham Elmahrek On Aug. 21, 2015, 7:54 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37672/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 7:54 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Fix warning in execution module > > > Diffs > ----- > > > execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java > 3f79325 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java > e07ddd7 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > 14fdfdc > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java > 6134106 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java > b81f4d6 > > Diff: https://reviews.apache.org/r/37672/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
