> On Aug. 21, 2015, 9 p.m., Abraham Elmahrek wrote: > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java, > > line 58 > > <https://reviews.apache.org/r/37672/diff/1/?file=1046559#file1046559line58> > > > > Private as well.
This will be updated. > On Aug. 21, 2015, 9 p.m., Abraham Elmahrek wrote: > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java, > > line 76 > > <https://reviews.apache.org/r/37672/diff/1/?file=1046560#file1046560line76> > > > > Might not be necessary if we create a constructor that consumes a > > partition? > > > > Also, error handling is missing. I'll create a constructor, thanks. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37672/#review96082 ----------------------------------------------------------- On Aug. 21, 2015, 7:54 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37672/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 7:54 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Fix warning in execution module > > > Diffs > ----- > > > execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java > 3f79325 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java > e07ddd7 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > 14fdfdc > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java > 6134106 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java > b81f4d6 > > Diff: https://reviews.apache.org/r/37672/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
