> On Aug. 21, 2015, 9 p.m., Abraham Elmahrek wrote: > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java, > > line 94 > > <https://reviews.apache.org/r/37672/diff/1/?file=1046557#file1046557line94> > > > > Charset.defaultCharset()
Hi Abe, thank you for the comment. We've started using UTF-8 for string serialization in SQOOP-2451. I've picked UTF-8 there as that was something we were assuming under the hood. My reasoning for not using defaultCharset() is that it can be different on different nodes (different slave nodes on the Hadoop cluster, Server and the client). I wanted to explicitly want to avoid situation when one node (let say Sqoop server) will serialize data with UTF-8, so that other node (let say mapper) will de-serialize them with different default encoding. Do you think that it make sense or would you prefer us to go back and use Charset.defaultCharset() elsewhere as well? Jarcec - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37672/#review96082 ----------------------------------------------------------- On Aug. 21, 2015, 7:54 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37672/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 7:54 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Fix warning in execution module > > > Diffs > ----- > > > execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java > 3f79325 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java > e07ddd7 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > 14fdfdc > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java > 6134106 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java > b81f4d6 > > Diff: https://reviews.apache.org/r/37672/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
